Tilde-decode custom page path variables, refs #1732#2849
Open
TowyTowy wants to merge 1 commit into
Open
Conversation
Wildcard custom pages (e.g. templates/pages/{topic}.html) passed the raw
tilde-encoded path segment straight into the template context, so a URL
like /topic_hello~20world rendered "hello~20world" instead of "hello
world" - and ids containing spaces or slashes never matched user data.
Tilde-decode the captured groups, matching how the database/table/row
url_vars are already decoded elsewhere in the router.
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcard custom pages (e.g.
templates/pages/{topic}.html) passed the raw tilde-encoded path segment straight into the template context. A URL like/topic_hello~20worldrenderedhello~20worldinstead ofhello world, so page variables containing spaces, slashes, or non-ASCII characters never matched the user's data (the original report in #1732).This tilde-decodes the captured route groups before adding them to the template context, matching how the database/table/row
url_varsare already decoded elsewhere in the router.Added
test_custom_route_pattern_decodes_path_variablescovering space (~20), UTF-8 (~C3~A9→café), and slash (~2F) encodings across single- and two-variable page routes. Fails before, passes after (170 tests green, no regressions).Prepared with AI assistance (Claude), reviewed and verified by me.